Skip to content

Commit

Permalink
Correct data for the RTCPeerConnection API (#12300)
Browse files Browse the repository at this point in the history
This PR corrects the data throughout the RTCPeerConnection API, which was a **big** mess, mostly due to copy-paste error.  The fixes include the following:

- Converts the "Promise-based version" notes into subfeatures.  It is more standard to use a subfeature rather than the notes.  Additionally, they were copied and pasted all across the Opera data, so it caused some major data discrepancies.  (Particularly, claiming support for features in Opera that weren't supported, wrong version numbers...)  Fixes #11158.
- Corrects the data regarding promise-based versions for Chrome.  After further digging in, it turns out that most of these features had the wrong version number.  New data comes from the commit history ([1](https://source.chromium.org/chromium/chromium/src/+/e16c96f5a5b517a64fdbc5be75f05e359e04b461), [2](https://source.chromium.org/chromium/chromium/src/+/70302a3d99ed149d59acf592edf9d32d4fd0dbda), [3](https://source.chromium.org/chromium/chromium/src/+/68f8e256dc7c7369127bd345100bcf776fa8acc0)).
- Corrects the Samsung Internet and Opera/Opera Android data. In the case of Samsung Internet, it appears to have been set to 6.0 most everywhere after a mirroring from the old, incorrect wiki data (#1606), and Opera's data initially came from the wiki tables (#1070).  When the Chrome data was corrected, however (see #3287), only the Chrome, Chrome Android, and WebView data was adjusted, leaving these other browsers untouched.
- Corrects the version number for `createDataChannel` based upon results from the mdn-bcd-collector project (v3.3.0).
- Finally, mirrors the Chrome data to both Chrome Android and WebView.  Both had been left as `true` for many of the features, however since we have ranged values, we're able to replace the `true` with `≤37` for WebView, and mirror Chrome straight to Chrome Android since we know Chrome Android has supported this API back then.
  • Loading branch information
queengooborg authored Sep 23, 2021
1 parent 9c61e78 commit fa197e9
Showing 1 changed file with 659 additions and 1,072 deletions.
Loading

0 comments on commit fa197e9

Please sign in to comment.