This repository has been archived by the owner on Oct 27, 2021. It is now read-only.
Add the receiver to method completions #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stamblerre
reviewed
Dec 26, 2018
internal/suggest/candidate.go
Outdated
| @@ -129,11 +130,19 @@ func (b *candidateCollector) asCandidate(obj types.Object) Candidate { | |||
| path = pkg.Path() | |||
| } | |||
|
|
|||
| receiver := "" | |||
| if sig, ok := typ.(*types.Signature); ok { | |||
| if receiverVar := sig.Recv(); receiverVar != nil { | |||
There was a problem hiding this comment.
simpler:
if sig.Recv() != nil {
receiver = types.TypeString(sig.Recv().Type(), func(*types.Package) string {
return ""
})
}
stamblerre
reviewed
Dec 26, 2018
internal/suggest/candidate.go
Outdated
| @@ -129,11 +130,19 @@ func (b *candidateCollector) asCandidate(obj types.Object) Candidate { | |||
| path = pkg.Path() | |||
| } | |||
|
|
|||
| receiver := "" | |||
stamblerre
reviewed
Dec 26, 2018
internal/suggest/candidate.go
Outdated
| if sig, ok := typ.(*types.Signature); ok { | ||
| if receiverVar := sig.Recv(); receiverVar != nil { | ||
| receiver = types.TypeString(receiverVar.Type(), func(*types.Package) string { return "" }) | ||
| if sig.Recv() != nil { |
There was a problem hiding this comment.
sorry, one last comment - you can avoid the nested if with:
if sig, ok := typ.(*types.Signature); ok && sig.Recv() != nil {
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
P.S. I think the type for method expressions already includes the first receiver argument without any further changes to our code. At least it did when I tried it.
This can be used to fix microsoft/vscode-go#2107