Fix basic authentication #20
Open
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I tested the gem with this update, it fixes an issues I've been having for quite some time, and it doesn't seem to break anything else. Any chance we'd get this merged soon plz ? |
|
Hello, It is all changes. Please merge it if you want. |
|
Hi @jotolo, unfortunately I do not have merge permissions for this repo. Also, this repo hasn't accepted a merge for 8 years now, so you can assume the owner abandoned the project. I think you could try publishing this PR to recent forks, and if that fails, consider maintaining your own. In any case, I would recommend you to add tests to document what use case you are fixing. Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.