Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ls_kinds property to experiment object #165

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add ls_kinds property to experiment object #165

merged 2 commits into from
Aug 1, 2024

Conversation

brianbolt
Copy link
Contributor

Description

  • Adds ls_kinds property to experiment object which fetches the list of ls_kind from the experiment data columns experiment value.

Related Issue

DISCO_1468

How Has This Been Tested?

  • Ran the code using an ETL script which uses the information to detect when an experiment ls_kind exists.

@brianbolt brianbolt requested a review from bffrost July 29, 2024 13:54
@brianbolt brianbolt changed the title Add ls_kinds property Add ls_kinds property to experiment object Jul 29, 2024
bffrost
bffrost requested changes Aug 1, 2024
View reviewed changes
acasclient/experiment.py Outdated Show resolved Hide resolved
@brianbolt brianbolt requested a review from bffrost August 1, 2024 17:52
bffrost
bffrost approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianbolt brianbolt merged commit 4bff62b into release/2024.3.x Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost