Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-699: Tests for restricting /api/experiments/protocolCodename/:code by project acls #138

Merged
merged 1 commit into from
Aug 17, 2023
Merged

ACAS-699: Tests for restricting /api/experiments/protocolCodename/:code by project acls #138

merged 1 commit into from
Aug 17, 2023

Conversation

brianbolt
Copy link
Contributor

Description

  • Tests for project acls filter on /api/experiments/protocolCodename/:code

Related Issue

ACAS-699

How Has This Been Tested?

Ran acasclient tests

@brianbolt brianbolt mentioned this pull request Aug 15, 2023
Merged
brianbolt
brianbolt commented Aug 15, 2023
View reviewed changes
tests/test_acasclient.py Show resolved Hide resolved
tests/test_acasclient.py Show resolved Hide resolved
hhan-schrodinger
hhan-schrodinger approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@hhan-schrodinger hhan-schrodinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - appreciate the readability!

@brianbolt brianbolt merged commit 4943c0f into release/2023.2.x Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhan-schrodinger hhan-schrodinger hhan-schrodinger approved these changes

@hweissig hweissig Awaiting requested review from hweissig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @hhan-schrodinger