Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue793 #795

Merged
merged 17 commits into from
Sep 15, 2021
Merged

Issue793 #795

merged 17 commits into from
Sep 15, 2021

Conversation

brianbolt
Copy link
Contributor

No description provided.

@brianbolt brianbolt requested a review from bffrost September 3, 2021 21:47
.env Outdated Show resolved Hide resolved
conf/docker/roo/environment/roo.env Show resolved Hide resolved
modules/CmpdReg/src/server/routes/CmpdRegRoutes.coffee Outdated Show resolved Hide resolved
modules/CmpdReg/src/server/routes/CmpdRegRoutes.coffee Outdated Show resolved Hide resolved
@brianbolt brianbolt requested a review from bffrost September 15, 2021 02:28
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed the latest set of changes and they all look good.
Similar to the other PR, would you mind going through my comments and resolving them once you believe they've been fixed?

@brianbolt brianbolt merged commit e7230e6 into feature/k8s Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants