Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-760: Warn users if Number values which contain numerics will be saved as Text #1154

Merged
merged 2 commits into from
Apr 29, 2024
Merged

ACAS-760: Warn users if Number values which contain numerics will be saved as Text #1154

merged 2 commits into from
Apr 29, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Apr 18, 2024 •
edited
Loading

Description

  • Produces warning if any values uploaded as a Number contain [0-9] but will be saved as Text.

Related Issue

ACAS-760

How Has This Been Tested?

Added acasclient test mcneilco/acasclient#162

@brianbolt brianbolt mentioned this pull request Apr 18, 2024
Merged
hhan-schrodinger
hhan-schrodinger approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@hhan-schrodinger hhan-schrodinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bffrost
bffrost approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor nits on the wording of the warning but otherwise LGTM. I took a look at a production server and looked for stringValues in Number columns and didn't find a wide variety, so I think the simple [0-9] grep will work.

modules/GenericDataParser/src/server/generic_data_parser.R Outdated Show resolved Hide resolved
@brianbolt brianbolt merged commit ac80812 into release/2024.2.x Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhan-schrodinger hhan-schrodinger hhan-schrodinger approved these changes

@dalejerikson dalejerikson dalejerikson approved these changes

@bffrost bffrost bffrost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianbolt @bffrost @dalejerikson @hhan-schrodinger