Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-718: Fallback LR ownership update to service user #1127

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Oct 24, 2023

Description

  • When creating an experiment, a user may have access to a project in ACAS but not in LiveDesign. In this case we cannot set the owner of a LiveReport created by ACAS to the logged in user.
  • The code now attempt to update the LiveReport owner but will fall back if there is an error to the service user who created the LiveReport.

Related Issue

ACAS-718

How Has This Been Tested?

Updated the code on a running server and verified that fall back messages were printed and the LiveReport was properly created when the user did not have permissions in LiveDesign.

Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will continue to update the folder and make the LR read-only, even if the user is missing permissions, but it'll gracefully catch & log if the LR owner can't be updated to the logged in user.

@brianbolt brianbolt merged commit 70dfbf7 into release/2023.2.x Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants