Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-678: Use sketcher_clear API to clear structure in MaestroChemicalStructureController. #1106

Merged
merged 3 commits into from
Jun 28, 2023
Merged

ACAS-678: Use sketcher_clear API to clear structure in MaestroChemicalStructureController. #1106

merged 3 commits into from
Jun 28, 2023

Conversation

iamanandkr
Copy link
Contributor

In the ACAS Compound Registration clicking on "New Salt" button produces the following traceback,

Uncaught TypeError: this.maestro.clearSketcher is not a function
    at MaestroChemicalStructureController.clear (ACASFormChemicalStructure.js:131:27)
    at child.show (Salt.js:174:37)
    at child.showAddSaltPanel (SaltForm.js:229:27)
    at HTMLDivElement.dispatch (jquery-1.7.2.min.js:3:4816)
    at HTMLDivElement.i (jquery-1.7.2.min.js:3:709)

Description

Maestro sketcher has the clear_sketcher API to clear the sketcher. Here, we replace the usage with the correct API. We also clear the sketcher for showing, but I ran into the situation where maestro was still not defined, so for now I have added logic to only clear the sketcher if it's available.

Related Issue

ACSAS-678

How Has This Been Tested?

I was able to reproduce the error on qa-demo-23-2 and then verified after the changes the error is no longer seen. I was able to save a salt and then reopen the sketcher and the sketcher state was clear.

@iamanandkr iamanandkr requested review from brianbolt and bffrost June 28, 2023 16:00
@iamanandkr iamanandkr self-assigned this Jun 28, 2023
bffrost
bffrost approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

brianbolt
brianbolt approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@brianbolt brianbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamanandkr iamanandkr merged commit 5f019f8 into release/2023.2.x Jun 28, 2023
@iamanandkr iamanandkr deleted the ACAS-678 branch June 28, 2023 16:51
iamanandkr added a commit that referenced this pull request Jun 29, 2023
@bffrost @iamanandkr
ACAS-678: Use sketcher_clear API to clear structure in MaestroChemica…
f95450c 
…lStructureController. (#1106) (#1107)

Co-authored-by: Anand Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianbolt brianbolt brianbolt approved these changes

@bffrost bffrost bffrost approved these changes

Assignees

@iamanandkr iamanandkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamanandkr @brianbolt @bffrost