Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade l4j #839

Closed
brianbolt opened this issue Dec 12, 2021 · 2 comments
Closed

Upgrade l4j #839

brianbolt opened this issue Dec 12, 2021 · 2 comments
Assignees

Comments

@brianbolt
Copy link
Contributor

No description provided.

@bffrost
Copy link
Collaborator

bffrost commented Dec 14, 2021

@brianbolt as we discussed yesterday, we're still seeing log4j 1.2.17 get pulled down due to the slf4j-log4j12 artifact.
These two classes seem to be used widely in acas-roo-server:

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Can we see if it's possible to switch our slf4j usage to use log4j v2.15.0 instead?
From my reading it seems we may need to switch from slf4j-log4j12 to log4j-over-slf4j and/or use log4j-slf4j-impl

https://stackoverflow.com/questions/31044619/difference-between-slf4j-log4j12-and-log4j-over-slf4j
https://logging.apache.org/log4j/2.x/log4j-slf4j-impl/
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-slf4j-impl/2.15.0

@brianbolt
Copy link
Contributor Author

It looks like we should take the log4j-slf4j-impl route. This is because it looks like we already went down the path of using jcl-over-slf4j and excluding commons-logging from various places. This stackoverflow comment gives some good guidance about the options

It looks like they released a log4j 2.16.0 which disables JNDI by default so I think i'll update to that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants