Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acas 3 misc #236

Merged
merged 20 commits into from
Dec 22, 2021
Merged

Acas 3 misc #236

merged 20 commits into from
Dec 22, 2021

Conversation

brianbolt
Copy link
Contributor

No description provided.

@brianbolt
Revert changes during testing period.
f7e1f48
@brianbolt
Only check standarder settings when standardizer turned on
4f0f1b2
@brianbolt
Fixing jchem structure search
2d49d22
@brianbolt
Revert image code changes
753fd17
@brianbolt
log error rather than dying when creating folder in prepare configs
8275732
@brianbolt
Fix duplicate run during startup
7a89f44
@brianbolt
throw error when standardization error
b4ce383
@brianbolt
Make standardization non-transactional
057da67
@brianbolt
improve log message
3aba13f
@brianbolt
better logging
2f98b40
@brianbolt
reduce logging
cbe5c6e
@brianbolt
actually standardize the structure
75538c2
@brianbolt
Make restandardiation not transactional to speed it up
4ed3fab
@brianbolt
better logging and actually save updated structures
3ff52fc
@brianbolt
Actually updates tructures when restandardizing
b43d4ea
@brianbolt
Return false if structure does not exist
0ebe87d
@brianbolt
Better log levels
15e7581
@brianbolt
Merge branch 'feature/bbchem' into ACAS-3-misc
da3493f
@brianbolt brianbolt requested a review from bffrost December 21, 2021 20:00
@brianbolt
Copy link
Contributor Author

Main changes here are:

  1. Make re-standardization non transactional to flush sessions to boost performance
  2. Revert jchem impl changes made during creation of bbchem impl
  3. Actually re-standardize structures

bffrost
bffrost requested changes Dec 21, 2021
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Just a few minor things to address. I think the persist vs merge one does need to be changed.

src/main/java/com/labsynch/labseer/service/StandardizationServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/com/labsynch/labseer/service/StandardizationServiceImpl.java Show resolved Hide resolved
src/main/java/com/labsynch/labseer/service/StandardizationServiceImpl.java Show resolved Hide resolved
src/main/java/com/labsynch/labseer/service/StandardizationServiceImpl.java Outdated Show resolved Hide resolved
@brianbolt brianbolt merged commit c591043 into feature/bbchem Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost