Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue820 #221

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Issue820 #221

merged 2 commits into from
Nov 4, 2021

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Nov 4, 2021 •
edited
Loading

I tested this on a server and verified it works correctly by running this curl which was previously throwing a null pointer exception.

curl http://localhost:3001/api/getContainerLocationTree

@brianbolt brianbolt requested a review from bffrost November 4, 2021 19:44
bffrost
bffrost approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much cleaner

@brianbolt brianbolt merged commit 7ad8ce7 into release/1.13.6 Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost