You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code review reveals that both Arduino_LoRaWAN_machineQ_base::NetBegin() and Arduino_LoRaWAN_ttn_base::NetBegin() call LMIC_setSession() with an incorect first parameter. It's annotated as /* port number */, and it's a constant value of 1. But that parameter is the NetID. Luckily this only matters for Class B in the LMIC; and we don't support that yet. But it should be fixed.
The text was updated successfully, but these errors were encountered:
Code review reveals that both
Arduino_LoRaWAN_machineQ_base::NetBegin()
andArduino_LoRaWAN_ttn_base::NetBegin()
callLMIC_setSession()
with an incorect first parameter. It's annotated as/* port number */
, and it's a constant value of 1. But that parameter is theNetID
. Luckily this only matters for Class B in the LMIC; and we don't support that yet. But it should be fixed.The text was updated successfully, but these errors were encountered: