Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino_LoRaWAN_*::NetBegin() functions don't call LMIC_setSession correctly #96

Closed
terrillmoore opened this issue Apr 13, 2019 · 0 comments
Assignees
Labels

Comments

@terrillmoore
Copy link
Member

Code review reveals that both Arduino_LoRaWAN_machineQ_base::NetBegin() and Arduino_LoRaWAN_ttn_base::NetBegin() call LMIC_setSession() with an incorect first parameter. It's annotated as /* port number */, and it's a constant value of 1. But that parameter is the NetID. Luckily this only matters for Class B in the LMIC; and we don't support that yet. But it should be fixed.

@terrillmoore terrillmoore self-assigned this Apr 13, 2019
terrillmoore added a commit that referenced this issue Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant