Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#366: Allow defining multiple configurations per ALM #367

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

mc1arke
Copy link
Owner

@mc1arke mc1arke commented Jun 5, 2021

The default distribution of Sonarqube only allows a single instance of each ALM to be configured, which prevents using ALM decoration where 2 different repositories require different API keys in a single ALM. To allow multiple configurations to be defined per ALM, the MultipleAlmFeatureProvider is being intercepted by the agent for the Web component and the enabled method being replace to always return true, thereby removing the limit on ALMs in the front-end.

The default distribution of Sonarqube only allows a single instance of each ALM to be configured, which prevents using ALM decoration where 2 different repositories require different API keys in a single ALM. To allow multiple configurations to be defined per ALM, the `MultipleAlmFeatureProvider` is being intercepted by the agent for the Web component and the `enabled` method being replace to always return `true`, thereby removing the limit on ALMs in the front-end.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

Copy link

@YTN01 YTN01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments.

@mc1arke mc1arke merged commit b3c9f54 into master Jun 7, 2021
@mc1arke mc1arke deleted the multi-alm-configuration branch June 7, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants