Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conversion function cannot contain javascript Template literals (Template strings) #39

Closed
mbehr1 opened this issue Dec 16, 2023 · 0 comments · Fixed by #40
Closed

conversion function cannot contain javascript Template literals (Template strings) #39

mbehr1 opened this issue Dec 16, 2023 · 0 comments · Fixed by #40
Labels
bug Something isn't working

Comments

@mbehr1
Copy link
Owner

mbehr1 commented Dec 16, 2023 •
edited
Loading

Problem is that ${} get's treated as an attribute and thus modified...
Need to exclude ${} replacement within conversionFunctions (or reduce to really only ${attributes..*}.
@mbehr1 mbehr1 added the bug Something isn't working label Dec 16, 2023
mbehr1 added a commit that referenced this issue Jan 7, 2024
@mbehr1
fix: lifecycle selection and attribute handling
b819bcb 
Issue: conversion function cannot contain javascript Template literals (Template strings) #39
@mbehr1 mbehr1 mentioned this issue Jan 7, 2024
Merged
@mbehr1 mbehr1 closed this as completed in #40 Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: attribute handling mbehr1/fishbone
1 participant
@mbehr1