Skip to content

Commit

Permalink
feat(notebook): add exec cell support for filter
Browse files Browse the repository at this point in the history
Filter from query or report can now be executed directly.
  • Loading branch information
mbehr1 committed Oct 8, 2023
1 parent 19b9cc0 commit 1835627
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion src/extension/fbaNBRQRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ export class FBANBRestQueryRenderer {
console.log(`FBANBRestQueryRenderer.executeCell()... cell.metadata=${JSON.stringify(cell.metadata)}`)
if (
cell.kind === vscode.NotebookCellKind.Code &&
(cell.document.languageId === 'javascript' || cell.document.languageId === 'fbJsonPath') &&
['jsonc', 'json', 'javascript', 'fbJsonPath'].includes(cell.document.languageId) &&
cell.metadata &&
cell.metadata.fbUidMembers &&
Array.isArray(cell.metadata.fbUidMembers)
Expand Down Expand Up @@ -625,6 +625,22 @@ export class FBANBRestQueryRenderer {
)
exec.end(true)
}
} else if (
fbUidMembers[fbUidMembers.length - 1].endsWith(':query') ||
fbUidMembers[fbUidMembers.length - 1].endsWith(':report')
) {
const filter = JSON5.parse(cell.document.getText())
appendMarkdown(exec, [{ summary: 'querying filter:', texts: [...codeBlock(JSON.stringify(filter, undefined, 2), 'json')] }])
const filterRq: RQ = {
path: 'ext:mbehr1.dlt-logs/get/docs/0/filters?', // todo get from cell data!
commands: [
{
cmd: 'query',
param: JSON.stringify(filter),
},
],
}
FBANBRestQueryRenderer.execRestQuery(editorProvider, exec, docData, filterRq, '', '')
} else {
exec.end(false)
}
Expand Down Expand Up @@ -659,6 +675,7 @@ export class FBANBRestQueryRenderer {

appendMarkdown(exec, [
{
open: jsonPath.length === 0 && convFunction.length === 0,
summary: `received ${resJson.data.length} messages${
resJson.data.length > msgs.length ? `. Unfold to see first ${msgs.length}` : resJson.data.length > 0 ? ':' : ''
}`,
Expand Down

0 comments on commit 1835627

Please sign in to comment.