-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configs appear to work only when opening DLT through NodeJS implementation #245
Comments
@Ulenspiegel hmm. that might well be the case. I'll take a look! |
Added e2e tests as well for the use-cases: - add filter with a config via settings - a filter part of a config is disabled by default - a filter of a config can be enabled/disabled via via tree item for the config TODO: not implemented yet: config.autoEnableIf... (sep PR follows) Issue: Configs appear to work only when opening DLT through NodeJS implementation #245
@Ulenspiegel see a first implementation for the adlt backend in PR#246. This is missing the config.autoEnableIf feature yet (are you using that?). Will add that as well next. |
@mbehr1 , amazing, and thank you; I will give it a test. I'm not using config.autoEnableIf so far (I've discovered the extension just recently, didn't adopt everything yet), so it won't break anything on my side. |
A couple of days of testing, so far looks like everything works perfectly well. :) |
I'm not quite certain if it's a known issue (or issue on my side), but it would seem that opening log files through built-in implementation or via adlt results in having no configs on the left pane (just flat list of filters). Opening the same file, in the same session, through deprecated NodeJS implementation does show the configs.
Minimal test setup included just the following in the config file:
No other extension-related configuration; opening same DLT file with two different methods results different views of the side panel:
The text was updated successfully, but these errors were encountered: