Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty categories while importing #789

Merged
merged 3 commits into from
May 22, 2024
Merged

Ignore empty categories while importing #789

merged 3 commits into from
May 22, 2024

Conversation

jakubkottnauer
Copy link
Contributor

@jakubkottnauer jakubkottnauer commented May 22, 2024 •
edited
Loading

  • Empty transaction categories in the imported CSV are now ignored
  • Added tests for this and the other fixes we've merged recently
  • Removed cursor-pointer class from the badge itself (the class is already provided by the _menu partial where we actually want the cursor to change)

Before:
Screenshot 2024-05-22 at 07 44 27

After:
Screenshot 2024-05-22 at 07 43 57

zachgoll
zachgoll approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left 2 small stylistic improvements to consider, but logic makes sense to me.

test/models/import_test.rb Show resolved Hide resolved
test/fixtures/imports.yml Outdated Show resolved Hide resolved
@jakubkottnauer jakubkottnauer force-pushed the import-empty-categories branch from 85c5a57 to 726b0df Compare May 22, 2024 11:09
@jakubkottnauer jakubkottnauer force-pushed the import-empty-categories branch from 726b0df to 2140666 Compare May 22, 2024 11:10
@zachgoll zachgoll merged commit 77f166a into maybe-finance:main May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgoll zachgoll zachgoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubkottnauer @zachgoll