Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budgeting V1 #1609

Merged
merged 20 commits into from
Jan 16, 2025
Merged

Budgeting V1 #1609

merged 20 commits into from
Jan 16, 2025

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented Jan 8, 2025

CleanShot.2025-01-15.at.15.25.15.mp4

@asdasdad23332s
Copy link

Hi @zachgoll, budgeting sounds like a really nice thing. Any estimate for the timing of the first public release for it?

@zachgoll
Copy link
Collaborator Author

@asdasdad23332s this week!

@zachgoll zachgoll marked this pull request as ready for review January 15, 2025 20:30
@zachgoll zachgoll merged commit 195ec85 into main Jan 16, 2025
5 checks passed
@zachgoll zachgoll deleted the zachgoll/budgeting-v1 branch January 16, 2025 19:36
Comment on lines +112 to +114
def categorizable?
to_account.accountable_type == "Loan"
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the idea behind adding this method?

Screenshot 2025-02-09 at 10 28 41 PM

This seems to have broken the transfer functionality automatically applying the Payment category since the first instance is an Accountable of type Loan whereas the credit card one is CreditCard.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea here is that a payment to a Credit Card account is not categorizable, so we prevent it by adding the Payment label (which cannot be modified).

A credit card payment is not an expense (all of the transactions on the credit card account are the expenses), while a payment to a loan account would be considered an expense because there are no corresponding transactions being generated on the loan itself.

This is aimed to increase the accuracy of budgeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants