Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect upload step #1323

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

enderahmetyurt
Copy link
Contributor

Fix #1322

@Shpigford
Copy link
Member

I agree with the bug, but we likely need a bit more nuance to where this redirects.

There's an uploaded? method on the Import model that checks for an uploaded file so maybe we need some sort of if/else or case statement to check for the current step and redirect to the appropriate one?

@enderahmetyurt
Copy link
Contributor Author

Good point @Shpigford. How does it look now?

@Shpigford
Copy link
Member

@enderahmetyurt Works for me! Thanks!

@Shpigford Shpigford merged commit 4a3685f into maybe-finance:main Oct 18, 2024
5 checks passed
@enderahmetyurt enderahmetyurt deleted the import-view-right-place branch October 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: View Import doesn't work as expected if the import file doesn't exist
2 participants