Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct delimiter on credit card zero values #1280

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

gariasf
Copy link
Contributor

@gariasf gariasf commented Oct 10, 2024

After recent fixes, the credit card view displays 0 by default on Minimum Payment and Annual Fee. However, the format is wrong. On zero values, the two digits after the delimiter are the decimals, and this is the current behaviour on other sections, like the dashboard.

For example, this is correct:
image
But this is not:
image

This PR resolves this issue, the credit card Minimum Payment and Annual Fee now display the correct delimiter on empty values:
image

I haven't seen any issues related to this, so I can't link one.

First time contributing and first time using ruby, I'll be happy to hear about your feedback.

Cheers.

Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zachgoll zachgoll merged commit 977da34 into maybe-finance:main Oct 10, 2024
4 checks passed
@gariasf gariasf deleted the gariasf/fix-card-format branch October 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants