Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing weekend stock prices in sync process #1242

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented Oct 4, 2024

There are a few different areas that we could potentially solve this issue:

  1. At the provider level (not a good option since we can't always control what the provider returns)
  2. At the base model level (i.e. Security::Price.find_prices)
  3. At the sync model level (i.e. Account::Holding::Syncer)

To keep the gapfill logic isolated from the base model, I've added a Gapfiller class that operates on the fetched prices directly in the sync process.

@zachgoll zachgoll merged commit 24d3c02 into main Oct 4, 2024
4 checks passed
@zachgoll zachgoll deleted the 1222-bug-investment-account-balances-should-handle-missing-stock-prices-for-weekends-and-holidays branch October 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Investment account balances should handle missing stock prices for weekends and holidays
1 participant