Add error handling for vehicle and property account creation

[tonyvince]

Close #1178

[zachgoll]

Could this be solved easier if we just apply client-side form validations?

I think we can add a required attribute on these fields and let the browser do all of this for us.

[Shpigford]

I think we can add a required attribute on these fields and let the browser do all of this for us.

I'm in favor of this for these types of low-stakes validations.

[zachgoll]

I think we can still remove all of these tests alongside the rescue handlers in the controller.

The form validation should handle all the main requirements directly in the browser. If a user somehow finds a way to side-step these, I'd rather the system raise an error so that we can capture it in observability systems like Sentry (rather than the user seeing an error message and the system acting as if nothing went wrong).

Following this logic, I think our existing create action in accounts_controller should probably not have the rescue block either (as I'm sure that was the pattern you followed here). In other words, we could probably remove this as well:

maybe/app/controllers/accounts_controller.rb

Lines 61 to 62 in fd40111

	rescue ActiveRecord::RecordInvalid => e
	redirect_back_or_to accounts_path, alert: e.record.errors.full_messages.to_sentence

[zachgoll]

We'll need to update this improper usage for this to flow through correctly:

maybe/app/views/accounts/_form.html.erb

Line 8 in fd40111

<%= money_with_currency_field f, :balance_money, label: t(".balance"), required: "required", default_currency: Current.family.currency %>

See required: "required" should be -> required: true