Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: When transaction drawer closed, turbo frame renders below main content #1167

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jestinjoshi
Copy link
Contributor

Fixes #1165

Explanation: HTML dialog should not be given CSS display property as it must be handled by the browser for hiding/showing the dialog

Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@zachgoll zachgoll merged commit 5178928 into maybe-finance:main Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When transaction drawer closed, turbo frame renders below main content
2 participants