Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UI warning states for holdings with missing data #1098

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Improved UI warning states for holdings with missing data #1098

merged 4 commits into from
Aug 16, 2024

Conversation

zachgoll
Copy link
Collaborator

Overview

  • Updates to tooltip controller
    • Removed arrow target (we likely won't need this ever based on our designs)
    • Added autoUpdate, which is necessary for keeping the position of the tooltip after the page has scrolled
  • Improved UI states for holdings with missing data that syncs up with "Issues" flow
  • Fixed the security prices issues flow

UI changes

Before
CleanShot 2024-08-16 at 15 03 51@2x

After

CleanShot 2024-08-16 at 15 38 02@2x

@zachgoll zachgoll merged commit 1b6ce6a into main Aug 16, 2024
4 checks passed
@zachgoll zachgoll deleted the zachgoll/better-ui-warnings-for-missing-prices branch August 16, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zachgoll