Add support for different column separator in csv import logic #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-constructor
force-pushed
the
csv-col-sep-support
branch
from
0786b96 to
fa4a42f
Compare
|
@code-constructor I think this all looks good and I'm definitely supportive of adding it in since a lot of non-US imports will have In terms of the UI, what do you think of grabbing this information on the very first step?
Long term, we'll probably take a second pass at the design of this entire feature and will put this in a more permanent place, but for now this seems like it gets the job done. |
code-constructor
force-pushed
the
csv-col-sep-support
branch
from
a4de931 to
91a5f70
Compare
code-constructor
force-pushed
the
csv-col-sep-support
branch
from
91a5f70 to
32856c0
Compare
|
Did an update of the Pull-Request. I've implemented your idea 👍. Thanks for the really fast response. Was a pleasure 🙏 |
zachgoll
reviewed
Aug 16, 2024
Co-authored-by: Zach Gollwitzer <[email protected]> Signed-off-by: Alexander Schrot <[email protected]>
|
Good catch & Committed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we all know, CSV is not always "comma separated values". It is often separated by other characters such as ";" or "|". This PR opens the model layer to support multiple column separators. The implementation is now able to import files with "," and ";" separators. More may come.
Important to know: The normalized representation
normalized_csv_stris still separated by comma (",").I would also like to implement the view support. But I don't want to do anything without a little guidance on what would be a good solution. Maybe just a selector below the upload field or a hidden section with "advanced import options".