Deposit, Withdrawal, and Interest Transactions for Investment View #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgoll
commented
Aug 10, 2024
| price: this.priceInputTarget | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a very rudimentary controller, highly coupled to the trade forms. Ideally we'll abstract this a bit in the future
zachgoll
deleted the
1050-user-can-create-depositwithdrawal-investment-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial concept of a dynamic trade / transaction form.
Account::EntryBuilderis the entrypoint where a flattened params hash can be passed in with atypeand then the relevant trade, transaction, or transfer is created based on this type.Likely will need to rework some of this as we add more types, but wanted to get this in so users can start building up portfolios.