New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minitest assert_nil warning #1070

Merged

zachgoll merged 3 commits into maybe-finance:main from tonyvince:fix-minitest-deprication-warnings

Aug 9, 2024

Contributor

tonyvince commented Aug 9, 2024 •

edited

Loading

To reproduce:

Run test suite bin/rails test
See warnings that will start failing in Minitest 6

DEPRECATED: Use assert_nil if expecting nil from test/models/account/holding/syncer_test.rb:106. This will fail in Minitest 6.
DEPRECATED: Use assert_nil if expecting nil from test/models/account/holding/syncer_test.rb:107. This will fail in Minitest 6.

tonyvince added 3 commits

August 9, 2024 11:19


          Fix minitest assert_nil warning

9cf30d1


          Remove empty line

24c651d


          Fix my stupidity

8ab0258

zachgoll merged commit 6bca35f into maybe-finance:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet