This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
GeoIP_record_by_addr leads to a core dump on an empty database for 127.0.0.1 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
oschwald
added a commit
that referenced
this pull request
Jul 13, 2015
GeoIP_record_by_addr leads to a core dump on an empty database for 127.0.0.1
oschwald
added a commit
that referenced
this pull request
Jul 28, 2015
1.6.6 * Replaced usage of deprecated fileno, read, and lseek on Visual Studio 2005+ with their ISO C++ conformant replacements. (Fix by ClaudiuHKS. GitHub #55.) * A warning about using a double as a float was fixed. (Fix by ClaudiuHKS. GitHub #56.) * Fixed segfault when doing a lookup on an empty database. (Fix by NesoK. GitHub #62.) * Fixed a memcheck error from valgrind in the `_check_mtime` function. (Reported by yurivct. GitHub #60.) * Fixed `_check_mtime` to check the return value of `gettimeofday` rather than just assuming it worked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
Open database via
GeoIP *db = GeoIP_open("./filename", GEOIP_MMAP_CACHE) ;
with GEOIP_MMAP_CACHE (or GEOIP_MEMORY_CACHE) options, after that, get a record via ip addr:
GeoIP_record_by_addr (db, "127.0.0.1");
then GeoIP_record_by_addr generates a core dump.
GeoIP_record_by_ipnum and GeoIP_record_by_name generates a core dummp, too.