This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Fix the MinGW build #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 👍 If you could create separate issues for the other problems you found, that would be great. The Windows support for this API is definitely lacking. |
oschwald
added a commit
that referenced
this pull request
Jan 12, 2015
1.6.4: Windows and Misc Updates * Update Fips codes (Boris Zentner) * Several issues with the MinGW build were fixed. (Thomas Pöchtrager. Github #46.) * Use a constructor in pread.c to ensure the critical section is always initialized. (Thomas Pöchtrager. Github #47.) * Added missing include of `io.h` on Windows. (Thomas Pöchtrager. Github #49.) * Fixed `configure` warning that `'missing' script is too old or missing`. (Reported by Floren Munteanu. Github #33.) * Previously `nmake /f Makefile.vc clean` would fail on Windows. This was fixed. * Obsolete win32 and NetWare make files were removed. * Numerous documentation updates. (Reported by Thomas Pöchtrager. GitHub #48.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both the static and shared MinGW build.
I stumbled over more possibly broken things while reading the source code.
For example, README.MinGW claims zlib is need to build GeoIP, but zlib.h isn't
included anywhere (well, besides in the outdated GeoIPWinDLL.patch file).
Another thing: It seems like the mutex in pread.c is never initialized
(DeleteCriticalSection() is missing too) when GeoIP is built as a static
library (probably just affects the MSVC build).