New Code in 1.6.4+ fails in VS2015 Release builds

[sgodin]

pread.c

Uses code from http://stackoverflow.com/a/2390626/1392778 for static initialization of critical section. This get's optimised out for VS2015 release builds - see comments in the stack overflow article that must have appeared after the code was intergrated into GeoIP pread.c.

Here is the block of code from my fix:

#ifdef _MSC_VER

 #pragma section(".CRT$XCU",read)

 #define INITIALIZER2_(f,p)                                             \
    static void __cdecl f(void);                                        \
    __declspec(allocate(".CRT$XCU")) void(__cdecl * f ## _) (void) = f; \
    __pragma(comment(linker,"/include:" p #f "_"))                      \
    static void __cdecl f(void)
 #ifdef _WIN64
 #define INITIALIZER(f) INITIALIZER2_(f,"")
 #else
 #define INITIALIZER(f) INITIALIZER2_(f,"_")
 #endif
#elif defined(__GNUC__)

 #define INITIALIZER(f)                               \
    static void f(void) __attribute__((constructor)); \
    static void f(void)

#endif

[oschwald]

Would you be willing to make the fix into a pull request?

[sgodin]

Sorry I'm pegged right now - just wanted to find the quickest way to make you guys aware, and save some others from the agony of tracking this down. :)

Scott

Sent from my iPhone

On Jul 13, 2016, at 3:28 PM, Gregory Oschwald [email protected] wrote:

Would you be willing to make the fix into a PR?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[oschwald]

@sgodin, thanks for letting us know.

@tpoechtrager, does this work for you? I think the original change was introduced in #47