Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for srcset #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added support for srcset #5

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2017

This is a basic check for srcset, it may contain filename.jpg x2 or filename.jpg x3, right now I've only "hard-coded" the x2.

Copy link

@specious specious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the history would be easier to understand if this was split into two commits, one just for stylistic changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant