cmake: remove -Werror #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
no-werror
branch
2 times, most recently
from
d1b99f3 to
ae547fe
Compare
JonasVautherin
previously approved these changes
Nov 4, 2019
|
9 months later, and I'm giving this another try 😄. |
julianoes
force-pushed
the
no-werror
branch
from
a62ea12 to
e3fbb8a
Compare
I think it's a better idea to only use -Werror in CI because: - This way the build is more robust when built for unknown environments with unknown compilers and compiler versions. - Many developers get confused by warnings and are blocked assuming they are actual errors.
julianoes
force-pushed
the
no-werror
branch
from
e3fbb8a to
b3668aa
Compare
|
Got it in within one year, come on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a better idea to only use -Werror in CI because:
Fixes #611.