Improve travis deployment #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying it on a tag (v0.17.1) and it seems to work 🎉 |
julianoes
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
backend_bin(which I believe we should rename, e.g. tomavsdk_backend, but I will open another PR to discuss that).Debugbuilds, as it doubles the build time and that's important when building with-DBUILD_BACKEND=ON. If we really need to build in Debug mode, we could make a nightly build, IMO.create_packages.shis now called bytravis-docker-build.sh, which IMO makes it cleaner since the later also callsfix_style.shandgenerate_docs.sh.create_packages.shtakes arguments now. The intent is to make it easier to use without relying on a convention like: "install intobuild/default/install/usr".create_packages.shcopies the files into a temp dir, and adds/usr/there. The benefit of this is that we don't have to build from scratch again just for packaging, improving the CI build time.