Add Status Text #733

douglaswsilva · 2019-04-26T22:05:09Z

Get status text through the SDK.

douglaswsilva · 2019-04-26T22:08:50Z

~~Will wait until Add mavlink messages support. MAVSDK-Proto#82 gets merged.~~
~~There are a couple of Keywords Anotacao in the code which means I'd like your guys' input.~~
I ran fix_style.h, but I'm afraid my computer is still not working correctly, so might have messed up some indentation, I'll most certainly need you guys to run it as well once we have made all PR changes.

JonasVautherin

Looking pretty good to me! The notes are probably more for Julian, I'm waiting to learn from his answers 👀.

plugins/telemetry/telemetry_impl.cpp

julianoes

A couple of comments but overall looks good. Thanks a lot!

core/mavlink_parameters.cpp

integration_tests/telemetry_async.cpp

plugins/telemetry/include/plugins/telemetry/telemetry.h

plugins/telemetry/telemetry_impl.cpp

julianoes

Something with the build fails now, can you check?

plugins/telemetry/telemetry_impl.h

douglaswsilva · 2019-05-02T17:27:41Z

@julianoes I just tested locally and it builds fine. Just updated everything from develop, ~~let's see if it will build~~. I think the problem is that you guys need to run fix.style from your computer. =/

julianoes · 2019-05-03T05:51:24Z

@douglaswsilva ok I've squashed your commits and removed the unrelated style changes (I have the same problem on Arch Linux though).

Let's see if CI is happy.

julianoes · 2019-05-03T06:22:16Z

@douglaswsilva ok it doesn't build yet if you include the backend:

make BUILD_BACKEND=1

This includes the addition for StatusText.

julianoes · 2019-05-03T06:31:16Z

Presumably the proto submodule was not updated. I've checked out master of the submodule and commited that.

JonasVautherin

Missing some doc, and then I believe we're good to go!

Generating docs for nested compound dronecode_sdk::Offboard::Attit/tmp/jenkins/workspace/Dronecode_DronecodeSDK_PR-733/install/include/dronecode_sdk/plugins/telemetry/telemetry.h:147: warning: Member type (variable) of class dronecode_sdk::Telemetry::StatusText is not documented.

…ics/DronecodeSDK into douglas/mavlinkDebugLogs # Conflicts: # plugins/telemetry/include/plugins/telemetry/telemetry.h

JonasVautherin

LGTM, thanks a lot @douglaswsilva!

I fixed the style, updated the proto submodule and merged develop. It passes all unit tests (backend + core) on my end.

JonasVautherin · 2019-05-04T00:38:03Z

Oh, still missing documentation:

Generating docs for nested compound dronecode_sdk::Offboard::Attit/tmp/jenkins/workspace/Dronecode_DronecodeSDK_PR-733/install/include/dronecode_sdk/plugins/telemetry/telemetry.h:147: warning: Member type (variable) of class dronecode_sdk::Telemetry::StatusText is not documented.

This includes the addition for StatusText.

…ics/DronecodeSDK into douglas/mavlinkDebugLogs # Conflicts: # plugins/telemetry/include/plugins/telemetry/telemetry.h

douglaswsilva · 2019-05-06T16:54:03Z

@JonasVautherin I added the description (actually it seems like one of you guys had done it already), but let me know if still doesn't work.

JonasVautherin

Looks good to me! Thanks @douglaswsilva!

douglaswsilva added 5 commits April 25, 2019 12:52

Implement MavMessage working. String only.

ff49a1b

Add enum.

2f9a26f

Rename it to StatusText.

2757765

Merge branch 'developOriginal' into douglas/mavlinkDebugLogs

e2c39cb

Run ./fix_style.sh .

9f7b2b6

douglaswsilva changed the title ~~Add Mavlink Status Text~~ [WIP] Add Mavlink Status Text Apr 26, 2019

douglaswsilva changed the title ~~[WIP] Add Mavlink Status Text~~ [WIP] Add Status Text Apr 27, 2019

JonasVautherin reviewed Apr 29, 2019

View reviewed changes

plugins/telemetry/telemetry_impl.cpp Outdated Show resolved Hide resolved

plugins/telemetry/telemetry_impl.cpp Outdated Show resolved Hide resolved

plugins/telemetry/telemetry_impl.cpp Show resolved Hide resolved

julianoes reviewed Apr 29, 2019

View reviewed changes

Some changes requested in PR regarding Removing status text rate.

b49eb7d

julianoes reviewed Apr 30, 2019

View reviewed changes

plugins/telemetry/telemetry_impl.h Outdated Show resolved Hide resolved

douglaswsilva added 2 commits April 30, 2019 10:17

Update branch.

4a7f87b

Remove comments.

703e6e8

douglaswsilva changed the title ~~[WIP] Add Status Text~~ Add Status Text May 2, 2019

douglaswsilva added 2 commits May 2, 2019 10:23

Include docstring.

e0984ab

Merge branch 'developOriginal' into douglas/mavlinkDebugLogs

f6e5ad9

douglaswsilva added 2 commits May 2, 2019 10:31

Add docstrings for SatusType enum.

03e1a09

Telemetry: implemented StatusText.

7c09c14

julianoes force-pushed the douglas/mavlinkDebugLogs branch from 03e1a09 to 7c09c14 Compare May 3, 2019 05:50

backend/proto: update submodule

43f988d

This includes the addition for StatusText.

JonasVautherin requested changes May 3, 2019

View reviewed changes

Merge branch 'douglas/mavlinkDebugLogs' of https://github.com/3drobot…

36c6d22

…ics/DronecodeSDK into douglas/mavlinkDebugLogs # Conflicts: # plugins/telemetry/include/plugins/telemetry/telemetry.h

JonasVautherin previously approved these changes May 3, 2019

View reviewed changes

julianoes dismissed JonasVautherin’s stale review via 612bdb6 May 6, 2019 11:12

douglaswsilva and others added 12 commits May 6, 2019 13:13

Implement MavMessage working. String only.

e32c6e0

Add enum.

2b62f7b

Rename it to StatusText.

be30238

Run ./fix_style.sh .

2aec7c9

Some changes requested in PR regarding Removing status text rate.

cf792db

Update branch.

2d71f47

Remove comments.

893689e

Include docstring.

ff4906a

Add docstrings for SatusType enum.

cce168e

Telemetry: implemented StatusText.

9ee7822

backend/proto: update submodule

18bcc00

This includes the addition for StatusText.

telemetry: fix docs

f8d20ca

julianoes force-pushed the douglas/mavlinkDebugLogs branch from 612bdb6 to f8d20ca Compare May 6, 2019 11:14

douglaswsilva added 2 commits May 6, 2019 09:48

Add missing doc for dronecode_sdk::Telemetry::StatusText.

2a34975

Merge branch 'douglas/mavlinkDebugLogs' of https://github.com/3drobot…

264ba7d

…ics/DronecodeSDK into douglas/mavlinkDebugLogs # Conflicts: # plugins/telemetry/include/plugins/telemetry/telemetry.h

JonasVautherin mentioned this pull request May 6, 2019

runBackend() now takes a connection url instead of a mavlink port mavlink/MAVSDK-Swift#121

Closed

fix style with clang-format 6 (clang-format 8 having a bug)

fcf91d8

JonasVautherin approved these changes May 6, 2019

View reviewed changes

JonasVautherin merged commit b706135 into mavlink:develop May 7, 2019

douglaswsilva mentioned this pull request May 7, 2019

Get mavlink messages through the SDK #721

Closed

douglaswsilva deleted the douglas/mavlinkDebugLogs branch October 21, 2019 20:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Status Text #733

Add Status Text #733

douglaswsilva commented Apr 26, 2019 •

edited

Loading

douglaswsilva commented Apr 26, 2019 •

edited

Loading

JonasVautherin left a comment

julianoes left a comment

julianoes left a comment

douglaswsilva commented May 2, 2019 •

edited

Loading

julianoes commented May 3, 2019

julianoes commented May 3, 2019

julianoes commented May 3, 2019

JonasVautherin left a comment

JonasVautherin left a comment

JonasVautherin commented May 4, 2019

douglaswsilva commented May 6, 2019

JonasVautherin left a comment

Add Status Text #733

Add Status Text #733

Conversation

douglaswsilva commented Apr 26, 2019 • edited Loading

douglaswsilva commented Apr 26, 2019 • edited Loading

JonasVautherin left a comment

Choose a reason for hiding this comment

julianoes left a comment

Choose a reason for hiding this comment

julianoes left a comment

Choose a reason for hiding this comment

douglaswsilva commented May 2, 2019 • edited Loading

julianoes commented May 3, 2019

julianoes commented May 3, 2019

julianoes commented May 3, 2019

JonasVautherin left a comment

Choose a reason for hiding this comment

JonasVautherin left a comment

Choose a reason for hiding this comment

JonasVautherin commented May 4, 2019

douglaswsilva commented May 6, 2019

JonasVautherin left a comment

Choose a reason for hiding this comment

douglaswsilva commented Apr 26, 2019 •

edited

Loading

douglaswsilva commented Apr 26, 2019 •

edited

Loading

douglaswsilva commented May 2, 2019 •

edited

Loading