camera: thread-safety fixes #699
Merged
+199
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
previously approved these changes
Mar 18, 2019
This tries to robustify the thread-safety of the camera plugin. Some of the callbacks and some shared data were not protected by mutexes. Also, all callbacks are not called from the thread pool workers reducing the chances for deadlocks.
julianoes
force-pushed
the
fix-camera-locks
branch
from
91dec68 to
d62ebc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to robustify the thread-safety of the camera plugin. Some of the callbacks and some shared data were not protected by mutexes.
Also, all callbacks are not called from the thread pool workers reducing the chances for deadlocks.
This work is in response to the stacktrace in #698.