Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix android build and update grpc dependencies #683

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

JonasVautherin
Copy link
Collaborator

@JonasVautherin JonasVautherin commented Feb 24, 2019

  • For some reason, Android now needs zlib to be compiled with -fPIC.
  • Update grpc dependencies (BoringSSL was failing to build on Android, and we were stuck on 1 year old dependencies 😅)

Builds on linux (default + android), macOS (default, ios, ios_simulator), passes the unit tests and apparently runs the examples fine on linux and iPad (e.g. telemetry, takeoff and land, mission, ...).

Notes:

@JonasVautherin JonasVautherin self-assigned this Feb 24, 2019
@@ -5,7 +5,7 @@ project(external-grpc)
include(ExternalProject)

set(ARG_GIT_REPOSITORY https://github.com/dronecore/grpc.git)
set(ARG_GIT_TAG enable-android-ios-build)
set(ARG_GIT_TAG 16856-fix-codegen-off-install)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@JonasVautherin JonasVautherin merged commit e5d4e0e into develop Feb 25, 2019
@JonasVautherin JonasVautherin deleted the fix-android-build branch February 25, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants