mission: make mission item comparison less strict #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we shouldn't compare doubles and floats of mission items with == but only compare it to an accuracy that makes sense for the use case. In case of latitude and longitude we are limited to 1e-7 anyway because the MAVLink transport happens over int at 1e7. Included in this change is to make use of the comparison in the ingration test.
JonasVautherin
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we shouldn't compare doubles and floats of mission items with == but only compare it to an accuracy that makes sense for the use case.
In case of latitude and longitude we are limited to 1e-7 anyway because the MAVLink transport happens over int at 1e7.
Included in this change is to make use of the comparison in the integration test.