info: expose new UUID (uid2) #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to query the new UUID using the info plugin. Vehicles only sending the old UUID (uid) are still supported if the uid2 is all zeros as specified.
bkueng
reviewed
Jan 7, 2019
This is just a unique ID, not actually a universally unique ID.
If the autopilot does not populate uid2 yet, we will just return 0. This way we're at least consistent.
JonasVautherin
previously approved these changes
Jan 8, 2019
thomasetter
reviewed
Jan 8, 2019
We should make sure the two fields have the same length using a static_assert since that's cleaner than doing a memset with zero and prevents us from doing an overrun in the memcpy.
julianoes
force-pushed
the
info-extend-uuid
branch
from
47c925f to
723ee9f
Compare
|
Well, somehow Jenkins decided this branch is "disabled" and not worth testing. Screw you Jenkins I'm merging it anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to query the new UUID using the info plugin.
Vehicles only sending the old UUID (uid) are still supported if the uid2 is all zeros as specified.
@bkueng or @thomasetter please review.