Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mission upload timeout: need to report the mission result #617

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Dec 4, 2018

The problem can be reproduced by:

  • comment out the handling of MAVLINK_MSG_ID_MISSION_ITEM_INT on the
    autopilot
  • run the mission upload example

Result: the async mission callback never gets called.

Output:

Uploading mission...
[05:35:39|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:39|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:40|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:40|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:40|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:40|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:41|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:41|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:41|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:41|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:42|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:42|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:42|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:42|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:43|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:43|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:43|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:43|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:44|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:44|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:44|Debug] MAVLink: critical: Operation timeout (system_impl.cpp:280)
[05:35:45|Warn ] Mission handling timed out while uploading mission. (mission_impl.cpp:1170)

The problem can be reproduced by:
- comment out the handling of MAVLINK_MSG_ID_MISSION_ITEM_INT on the
  autopilot
- run the mission upload example

Result: the async mission callback never gets called.

Output:
Uploading mission...
[05:35:39|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:39|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:40|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:40|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:40|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:40|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:41|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:41|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:41|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:41|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:42|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:42|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:42|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:42|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:43|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:43|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:43|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:43|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:44|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:44|Debug] Send mission item 0 (mission_impl.cpp:996)
[05:35:44|Debug] MAVLink: critical: Operation timeout (system_impl.cpp:280)
[05:35:45|Warn ] Mission handling timed out while uploading mission. (mission_impl.cpp:1170)
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oha! Thx 😄

@julianoes julianoes merged commit e022222 into mavlink:develop Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants