Improve info plugin #608
Merged
Improve info plugin #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API did not work as intended for the info plugin because the request was actually not carried out if the UUID was already determined. Therefore, we are now exposing just the part of actually sending the request message and therefore enabling the info plugin.
This adapts the info API to be more consistent with other plugins and return a pair with a result and the actual struct. It also changes the retry mechanism to use call_every instead of subscribing to the heartbeat and using that as a timeout trigger.
This is only a minimal addition to the backend to get the version of the info plugin.
| @@ -477,14 +477,8 @@ void SystemImpl::request_autopilot_version() | |||
|
|
|||
| _autopilot_version_pending = true; | |||
|
|
|||
| // We don't care about an answer, we mostly care about receiving AUTOPILOT_VERSION. | |||
| MAVLinkCommands::CommandLong command{}; | |||
| send_autopilot_version_request(); | |||
| switch (result) { | ||
| case Result::SUCCESS: | ||
| return "Success"; | ||
| case Result::INFORMATION_NOT_RECEIVED_YET: |
There was a problem hiding this comment.
Is that one in the Swift implementation? I believe I saw only SUCCESS and UNKNOWN 🤔
There was a problem hiding this comment.
Bumping minor because we added the info version in backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the info API to be more consistent with other plugins and return a pair with a result and the actual struct.
It also changes the retry mechanism to use call_every instead of subscribing to the heartbeat and using that as a timeout trigger.