Add -Weffc++ #597
Merged
Add -Weffc++ #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JonasVautherin I only did the core, plugins, integration tests. I would appreciate it if you could add everything backend related. |
|
I'll try to have a look as soon as I get time to look into the build system, but right now I have much higher-priority tasks to finish 😕. |
julianoes
force-pushed
the
add-effcpp
branch
from
16556e4 to
f703590
Compare
I want to add the effc++ warning because we had a bug where a member variable was not initalized and this resulted in random behavior. Really, this is something that the compiler should catch, no matter what!
julianoes
force-pushed
the
add-effcpp
branch
from
f703590 to
9c24c6b
Compare
|
@JonasVautherin please review so we can get it in and avoid conflicts. |
In the previous commit, we accidentally changed the init value of this variable, therefore we change it back.
| @@ -197,7 +197,7 @@ class TelemetryImpl : public PluginImplBase { | |||
|
|
|||
| // The ground speed and position are coupled to the same message, therefore, we just use | |||
| // the faster between the two. | |||
| double _ground_speed_ned_rate_hz{1.0}; | |||
| double _ground_speed_ned_rate_hz{0.0}; | |||
There was a problem hiding this comment.
Mouaha I had missed that.
JonasVautherin
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add the effc++ warning because we had a bug where a member variable was not initalized and this resulted in random behavior. See #596.
Really, this is something that the compiler should catch, no matter what!