Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ActionResult back to Action:Result #595

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Move ActionResult back to Action:Result #595

merged 2 commits into from
Nov 19, 2018

Conversation

julianoes
Copy link
Collaborator

Cherry-picked from #501.

@julianoes julianoes mentioned this pull request Nov 19, 2018
Closed
@hamishwillee
Copy link
Collaborator

Is this the beginning of moving everything or a one-off? Note, requires a bit of change in the docs.

@julianoes
action: Move ActionResult back into Action::Result
a69f1d6 
I do this because it makes it is more readable, is consistent with other
enums, structs used in a plugin class, and also because it is
inconsistent with other plugins and therfore made the pybind stuff hard.
@julianoes
example: fix after ActionResult -> Action::Result
6add7f0
@julianoes
Copy link
Collaborator Author

Is this the beginning of moving everything or a one-off? Note, requires a bit of change in the docs.

So actually, Action::Result, Telemetry::Result, etc. was the default for all videos but we had changed Action::Result to ActionResult as a one off and realized later it was not necessarily needed and not consistent with the rest, so now we moved it back.

@JonasVautherin JonasVautherin merged commit ae933c5 into develop Nov 19, 2018
@JonasVautherin JonasVautherin deleted the fix-action-results branch November 19, 2018 10:50
@hamishwillee hamishwillee mentioned this pull request Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianoes @hamishwillee @JonasVautherin