Improve VTOL example #586
Merged
Improve VTOL example #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to warn for this case because it's ok to just get the dummy system.
This improves the readability of the VTOL example, and also adds some more action to it by sending it South using `goto_location`.
JonasVautherin
approved these changes
Nov 6, 2018
| #include <chrono> | ||
| #include <cstdint> | ||
| #include <iostream> |
There was a problem hiding this comment.
Just to mention it: my preference for headers is to include them in alphabetical order. dronecode is a dependency of the example, just as thread. Alphabetical order is always consistent, where the preference of the developer, well, depends on the developer :-).
There was a problem hiding this comment.
Right, but I'm the correct developer 😄
| #define ERROR_CONSOLE_TEXT "\033[31m" // Turn text on console red | ||
| #define TELEMETRY_CONSOLE_TEXT "\033[34m" // Turn text on console blue | ||
| #define NORMAL_CONSOLE_TEXT "\033[0m" // Restore normal console colour | ||
| static constexpr auto ERROR_CONSOLE_TEXT = "\033[31m"; |
There was a problem hiding this comment.
Always happy to have less macros 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the readability of the VTOL example, and also adds some
more action to it by sending it South using
goto_location.