Add plugin to set params #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactoring which enables better type checking for parameters. The main change is that the type now needs to be passed to set_param which means the user of the API needs to know the type of a param that should be changed beforehand. This means that the actual type checking can happen inside the MAVLinkParameters class for both params that are set and params that are gotten.
Since the parameter interface has been refactored a bit, we now need to pass on the parameter type from the xml definition before doing a get_param.
In the case where we don't know about a parameter from the definition file, there is no point in trying to get it from the camera anyway. This is just an error.
This plugin enables setting and getting of raw parameters.
Param names can be 16 chars at most (plus zero termination).
This changes the bool indicating success to an enum for different results indicating success or different errors.
It's more intuitive to use the actual length (without zero termination) for the define and then add +1 if required. It turns out that when doing `strcmp`, we shouldn't compare 17 chars, so including the zero termination but only 16 chars.
julianoes
force-pushed
the
add-raw-params
branch
from
ed09f65 to
9f50fb1
Compare
JonasVautherin
approved these changes
Nov 14, 2018
|
How did you test PARAM_EXT? I didn't think anything other than QGC and Camera Manager used them. |
|
And just For my information, is the message flow for PARAM_EXT-* the same as for the normal param protocol (though obviously with the new messages)? |
Yuneec E90 😄
It's pretty much the same except that you also have the ack/nack that you can return. @dogmaphobic would know the details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a plugin to set/get "raw" mavlink params.
This has been tested against the E90.
When setting int parameters, we get an error but the param change still works. Hopefully, this will be fixed on the Firmware side: PX4/PX4-Autopilot#10792