Fix docker working directory #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
Thanks @julianoes . This all looks good to me (by inspection, not testing)
|
I was hoping to fix the Jenkins build today and then merge this. And after that we can rebase the other PRs and get them in as well. |
The docker working directory has been changed which required a rebuild.
julianoes
force-pushed
the
fix-docker-after-rename
branch
from
ed4772f to
f89e7bd
Compare
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
Fix docker working directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up by @hamishwillee we need to change the docker working directory. This required to rebuild the docker images and therefore also update the tags in the Jenkinsfile.