Parallelize the builds of dependencies #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
approved these changes
Jun 21, 2018
|
Thanks @thomasetter. However, the recommended way to build is just https://github.com/dronecore/DroneCore/blob/d1a5342637e49c204a96ed7aba74eba112117405/Makefile#L22 Since we were considering to move away from the magic Makefile to plain cmake your change is great though. |
|
Oh, I had not realized that. Thanks Julian! |
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
Parallelize the builds of dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit just sets the number of jobs used by make to the number of cpus in the system. This greatly accelerated builds on my system.
I might have more cores than most, but with all current-gen laptops having at least 8 (hyper-/SMT) threads, this should give a nice boost for most users.
TESTED:
git clone https://github.com/thomasetter/DroneCore.git --recurse-submodules -j 20 && cd DroneCore/ && mkdir build && cd build && cmake .. && make -j12