Mission pause #405
Merged
Mission pause #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
requested changes
May 22, 2018
| MissionServiceImplPauseTest, | ||
| ::testing::ValuesIn(generateInputPairs())); | ||
|
|
||
| ACTION_P2(SaveResult, callback, callback_saved_promise) |
There was a problem hiding this comment.
This ACTION_P2 is already defined above. I believe you don't need to redefine it here. Can you test without it? :)
JonasVautherin
approved these changes
May 22, 2018
There was a problem hiding this comment.
LGTM, building and passing the unit tests on my side.
Thanks @Sushma7785!
JonasVautherin
force-pushed
the
mission-pause
branch
from
b54505a to
e15c682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #350.