Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: added ping capability #1156

Merged
merged 2 commits into from
Nov 20, 2020
Merged

core: added ping capability #1156

merged 2 commits into from
Nov 20, 2020

Conversation

julianoes
Copy link
Collaborator

No description provided.

JonasVautherin
JonasVautherin reviewed Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this being a draft PR?

@julianoes
Copy link
Collaborator Author

Is there a reason for this being a draft PR?

Sorry, yes. There is still a debug printf in there. I'll update this soon.

@julianoes julianoes marked this pull request as ready for review November 20, 2020 10:36
@julianoes
Copy link
Collaborator Author

Ready for review and merging.

JonasVautherin
JonasVautherin previously approved these changes Nov 20, 2020
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianoes julianoes merged commit 496795c into develop Nov 20, 2020
@julianoes julianoes deleted the pr-ping branch November 20, 2020 14:40
@hshakula
Copy link

What was the reason for this feature?

@julianoes
Copy link
Collaborator Author

Good question @hshakula, I don't remember, I guess just implementing the MAVLink ping protocol, which allows to get an estimate of the return latency.

However, according to PING we should use SYSTEM_TIME instead.

Why do you ask?

@hshakula
Copy link

No particular reason. I was just analyzing MAVLink traffic in my network. And with 6 MAVSDK-based components per one system, when each of them does broadcast pings, I could not leave it unnoticed. So I decided to figure out why is it even needed. Considering it's there just for the sake of being there, I intend to disable this.

@julianoes
Copy link
Collaborator Author

That's a good point. We could make it opt-in, or at least opt-out with an env variable. Would that help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianoes @hshakula @JonasVautherin