-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing issue #39 #40
fixing issue #39 #40
Conversation
@mattphillips can you review PR |
oh man it will be so nice this can be in :D |
+1 |
I'm also having the same issue, can this be merged please? |
For now, In the meantime, I've temporarily solved the problem this way: npm i -D https://github.com/alexneo2003/jest-expect-message#issue-39
cd ./node_modules/jest-expect-message
npm i
npm run build
cd ../../ It is also possible to automate the build so that it is not removed after // ...
"postinstall": "cd ./node_modules/jest-expect-message && npm i && npm run build && cd ../../",
// ... 🍻 cheers |
@GerkinDev @golergka @Shakes03 @adamchenwei @beatrichartz @jkoenig134 @ambroselittle setupFilesAfterEnv: ['@alex_neo/jest-expect-message'], |
This is great, thank you. Hope though that the original package owner will get some time to merge PRs |
@alexneo2003, confirmed works on mine. thank you. |
@mattphillips Is there any chance that this can get merged? Or how about moving it to https://github.com/orgs/jest-community so it doesn't rely on a single person? |
Check this |
@mattphillips - I know this has been mentioned a few times here already, but would love if this could get merged in if you have a chance! Thank you, and thank you @alexneo2003 for the fix! |
I also would like this to be merged @mattphillips thanks |
@jongio I noticed you are the other contributors of this repository. Do you have the ability to merge this feature in? Thanks! |
Sorry, I do not. |
I hit this issue today and would also like it to be merged. @mattphillips do you need any help? |
@mattphillips I suggest you add another maintainer. Jest 27 was released a good long while ago. |
How to skip such type of warnings?
|
What would you think about giving the Jest community a nice Christmas gift, @mattphillips ? 🎄🙏😁 |
I think this highlights why this functionality should've been part of core from the beginning. |
My 2 cents mean little here, but this is a good fix and retains backwards-compatibility. I will note for others that I found |
@mattphillips hello? |
@jongio do you have any ability to add maintainers? It's been almost 6 months since I pinged Matt Phillips about this and 9 months since this ticket was opened. |
No sorry. |
Blatantly stolen from mattphillips#40
Please. There must be a way we can merge this. |
Since this hasn't been fixed in a year, I've gone ahead and published a new version of the package: I'll mark this package as deprecated if the official |
Sorry for the delay. Thanks for the fix @alexneo2003 |
Fix is available in: https://www.npmjs.com/package/jest-expect-message/v/1.0.4 |
fixing issue #39
support jest >= 27