Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue #39 #40

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

alexneo2003
Copy link
Contributor

@alexneo2003 alexneo2003 commented Jun 9, 2021

fixing issue #39
support jest >= 27

@alexneo2003
Copy link
Contributor Author

@mattphillips can you review PR

@adamchenwei
Copy link

oh man it will be so nice this can be in :D

@Shakes03
Copy link

+1

@golergka
Copy link

I'm also having the same issue, can this be merged please?

@GerkinDev
Copy link

GerkinDev commented Jun 21, 2021

For now, jest-expect-message breaks all my build/check pipelines. @alexneo2003 seen that the repo owner @mattphillips seems too busy to merge this right now (I totally get it, he got a life and a job), would it be possible for you to build the package & commit + push built artifacts on github out of this PR ? I won't ask for support, I just want my CI to stop yelling at me 😭 .

In the meantime, I've temporarily solved the problem this way:

npm i -D https://github.com/alexneo2003/jest-expect-message#issue-39
cd ./node_modules/jest-expect-message
npm i
npm run build
cd ../../

It is also possible to automate the build so that it is not removed after npm install by adding a script in package.json:

// ...
    "postinstall": "cd ./node_modules/jest-expect-message && npm i && npm run build && cd ../../",
// ...

🍻 cheers

@alexneo2003
Copy link
Contributor Author

alexneo2003 commented Jun 22, 2021

@GerkinDev @golergka @Shakes03 @adamchenwei @beatrichartz @jkoenig134 @ambroselittle
i'm publishing package @alex_neo/jest-expect-message
check pls
connect to project as

  setupFilesAfterEnv: ['@alex_neo/jest-expect-message'],

@GerkinDev
Copy link

This is great, thank you.

Hope though that the original package owner will get some time to merge PRs

@ambroselittle
Copy link

@alexneo2003, confirmed works on mine. thank you.

@Trainmaster
Copy link

Trainmaster commented Aug 6, 2021

@mattphillips Is there any chance that this can get merged? Or how about moving it to https://github.com/orgs/jest-community so it doesn't rely on a single person?

@alexneo2003
Copy link
Contributor Author

@mattphillips Is there any chance that this can get merged? Or how about moving it to https://github.com/orgs/jest-community so it doesn't rely on a single person?

Check this

@gracepark
Copy link

@mattphillips - I know this has been mentioned a few times here already, but would love if this could get merged in if you have a chance! Thank you, and thank you @alexneo2003 for the fix!

@DanKaplanSES
Copy link

I also would like this to be merged @mattphillips thanks

@DanKaplanSES
Copy link

@jongio I noticed you are the other contributors of this repository. Do you have the ability to merge this feature in? Thanks!

@jongio
Copy link
Contributor

jongio commented Aug 31, 2021

Sorry, I do not.

@wycats
Copy link

wycats commented Oct 14, 2021

I hit this issue today and would also like it to be merged. @mattphillips do you need any help?

@jcollum
Copy link

jcollum commented Oct 15, 2021

@mattphillips I suggest you add another maintainer. Jest 27 was released a good long while ago.

@orihomie
Copy link

orihomie commented Oct 26, 2021

How to skip such type of warnings?

ts-jest[ts-compiler] (WARN) test/e2e/example.e2e.ts:110:19 - error TS2554: Expected 1 arguments, but got 2.

Coridyn added a commit to widgetworks/jest-expect-message that referenced this pull request Dec 21, 2021
@rinogo
Copy link

rinogo commented Dec 30, 2021

What would you think about giving the Jest community a nice Christmas gift, @mattphillips ? 🎄🙏😁

@phawxby
Copy link

phawxby commented Jan 11, 2022

I think this highlights why this functionality should've been part of core from the beginning.

@KosnIre
Copy link

KosnIre commented Jan 15, 2022

My 2 cents mean little here, but this is a good fix and retains backwards-compatibility.

I will note for others that I found jest-chain has a similar issue where one of the commenters suggests using the patch-package project.

@slavafomin
Copy link

@mattphillips hello?

@jcollum
Copy link

jcollum commented Mar 15, 2022

@jongio do you have any ability to add maintainers? It's been almost 6 months since I pinged Matt Phillips about this and 9 months since this ticket was opened.

@jongio
Copy link
Contributor

jongio commented Mar 15, 2022

No sorry.

tlindsay added a commit to fastly/jest-expect-message that referenced this pull request Apr 4, 2022
@thephilwells
Copy link

Please. There must be a way we can merge this.

@jongio
Copy link
Contributor

jongio commented Apr 19, 2022

@HumbertoL
Copy link

Since this hasn't been fixed in a year, I've gone ahead and published a new version of the package: jest-27-expect-message.

I'll mark this package as deprecated if the official jest-expect-message is ever updated

https://www.npmjs.com/package/jest-27-expect-message

@mattphillips
Copy link
Owner

Sorry for the delay. Thanks for the fix @alexneo2003

@mattphillips mattphillips merged commit 7004dde into mattphillips:master Sep 8, 2022
@mattphillips
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.